Fix EOF errors when reading at file rotation boundaries#46
Open
dreamerns wants to merge 1 commit intonsqio:masterfrom
Open
Fix EOF errors when reading at file rotation boundaries#46dreamerns wants to merge 1 commit intonsqio:masterfrom
dreamerns wants to merge 1 commit intonsqio:masterfrom
Conversation
When reading from completed files at maxBytesPerFileRead boundary, the reader would attempt to read the message header before checking if it should rotate to the next file. This caused EOF errors and incorrectly marked valid files as corrupted (.bad). Added pre-rotation check in readOne() that rotates to the next file before attempting to read when readPos >= maxBytesPerFileRead. The check only applies to completed files (readFileNum < writeFileNum) to avoid advancing past the current write file. Tests added: - TestLargeMessageBoundary: Verifies file rotation with large messages - TestReadCurrentWriteFile: Ensures reader doesn't advance past write file
|
感谢您的来信，我尽快回复您！
|
houkx
reviewed
Jan 14, 2026
| if d.readFileNum < d.writeFileNum && d.readPos >= d.maxBytesPerFileRead { | ||
| if d.readFile != nil { | ||
| d.readFile.Close() | ||
| d.readFile = nil |
There was a problem hiding this comment.
fn := d.fileName(d.readFileNum)
os.Remove(fn)
|
感谢您的来信，我尽快回复您！
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading from completed files at maxBytesPerFileRead boundary, the reader would attempt to read the message header before checking if it should rotate to the next file. This caused EOF errors and incorrectly marked valid files as corrupted (.bad).
Added pre-rotation check in readOne() that rotates to the next file before attempting to read when readPos >= maxBytesPerFileRead. The check only applies to completed files (readFileNum < writeFileNum) to avoid advancing past the current write file.
Tests added: